Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FsTable and FsRangeBase inerhitance fable issues #56

Open
Freymaurer opened this issue Jul 31, 2023 · 5 comments
Open

[BUG] FsTable and FsRangeBase inerhitance fable issues #56

Freymaurer opened this issue Jul 31, 2023 · 5 comments
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@Freymaurer
Copy link
Collaborator

image

ColumnCount is part of the inheritance of FsRangeBase. Using this language construct the transpiled javascript code i not easily accessible FsRangeBase__ColumnCount(fstable). Maybe this needs some testing or must be refactored

@Freymaurer Freymaurer added the bug Something isn't working label Jul 31, 2023
@omaus
Copy link
Collaborator

omaus commented Jul 31, 2023

Is inheritance in general a problem for Fable? Or for JS?
Must we replace all inheritance?
@Freymaurer

@Freymaurer
Copy link
Collaborator Author

From what i see inerhitance does not work the same way in js. it is transpiled such that the code still works. but ColumnCount is not a member of FsTable, but of FsRangeBase. Js Syntax could be improved by adding "[]" to FsBaseRange, but i don't think this will make the fsrangebase members accessible from fstable.

@omaus
Copy link
Collaborator

omaus commented Jul 31, 2023

So if I understand you correctly, it is a must to have no inheritance in F# projects that you want to have transpiled to JS.

@Freymaurer
Copy link
Collaborator Author

AttachMembers would make it usable, albeit a bit unintuitive.

@HLWeil
Copy link
Member

HLWeil commented Jul 31, 2023

Same question as in the other issue: Do we need these classes easily accessible? The frontend API should be designed in a way that you don't have to mingle with them.

@kMutagene kMutagene added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed bug Something isn't working labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
None yet
Development

No branches or pull requests

4 participants