Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgMT-Assign Books -Email notification is sent to a user even if no books are assigned #128

Open
AnnCherianA opened this issue Feb 3, 2021 · 9 comments · Fixed by #152
Open
Assignees
Labels
bug Something isn't working

Comments

@AnnCherianA
Copy link

AnnCherianA commented Feb 3, 2021

Issue Description: In the 'assign books' tab even if books are not selected for assignment, email notification is incorrectly sent to the user informing of work assignment.
AgMT- Email notification sent to user even if books are not selected for assignment

Steps: Login as Admin
Select Create/Assign projects
Select a language combination such as English -> Aari
Select assign users
In the users list page, select the book tab .
When the list of books are displayed, do not select any book
Click Assign
Observation: Without selecting any books for assignment along with the alert message saying user role updated , an email notification is sent to the user saying Books assigned in the selected project.
Expected Result: The email notification should be sent only if there are books assigned or there is any change such as book unassigned .

@AnnCherianA AnnCherianA added the bug Something isn't working label Feb 3, 2021
@Joel-C-Johnson Joel-C-Johnson self-assigned this Feb 5, 2021
@AnnCherianA
Copy link
Author

@Savithamark please test this issue and share the results.

@savithasusannamark
Copy link

savithasusannamark commented Aug 17, 2021

If user does not select any books and click on assign,email is sent to the user that " books are assigned", and even if the assined books are unselected and click on assign, it is sending the same email that " books are assigned":
@Savithamark Screenshot not required at this point ,since the focus is on basic QA.

@AnnCherianA
Copy link
Author

@Savithamark please move to next step

@savithasusannamark
Copy link

Issue can be moved to "New Issues"

@AnnCherianA
Copy link
Author

@Savithamark ,as per testing process , it is not supposed to move to New Issues.

@savithasusannamark
Copy link

Issue can be moved to In progress

@AnnCherianA
Copy link
Author

Logged in as admin. In Create/assign projects tab, cleared the assigned books and
the below error was observed
image
Expected : If assigned books are unchecked(unassigned), then the alert should be such that the user is updated clearly such as 'Books unassigned'

@AnnCherianA
Copy link
Author

On assigning a new book , the alert /error message is again misleading.
Assigned books and found incorrect alert

@AnnCherianA
Copy link
Author

Tested the following cases

  • Cleared an already assigned book - Result - alet - book assignment updated appears
    image
  • Assigned a new book. - The same alert appears

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants