Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On trying to uncheck the assigned books, the message displayed ( user role updated ) is misleading -->Books updated #118

Open
AnnCherianA opened this issue Jan 12, 2021 · 9 comments · Fixed by #152
Assignees
Labels
bug Something isn't working

Comments

@AnnCherianA
Copy link

Issue Description :A message saying User Role is updated,is displayed on trying to uncheck some of the selected Books assigned to a user
Steps:
Login as an admin
Select Create/Assign Projects
Click Assign Users
Select a Book . Eg Hos
Select Assign
Uncheck the already selected books, if any (already assigned books)

Observation: A message saying User Assignment :User Role updated is displayed

Expected Result:
The message should say" Books updated" and not user role updated, which is misleading
AgMT-User Role updated to be changed -on deselecting boks to Books updated

@Joel-C-Johnson
Copy link
Contributor

Needs to handle this from the API side

@AnnCherianA
Copy link
Author

AnnCherianA commented Mar 12, 2021

@Joel-C-Johnson please share the issue link created in API Vachan repo.Once it is fixed there, this can move to in progress

@Joel-C-Johnson
Copy link
Contributor

@AnnCherianA
Copy link
Author

@Joel-C-Johnson as per the update on this link , Kavitha closed the issue and re-opened. Please check with Kavitha and update the status. If the issue is open or in progress from API side, here also, you can move to In-Progress.

@AnnCherianA
Copy link
Author

Un-assign books throws an error and still does not display the appropriate alert to the user.

@AnnCherianA
Copy link
Author

image

@AnnCherianA
Copy link
Author

On unchecking the assigned books, the alert displayed is now appropriate -books udpated

@AnnCherianA
Copy link
Author

image

@AnnCherianA
Copy link
Author

Verified that the alert is now correctly displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants