Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make php.ini more granular #6

Open
freephile opened this issue May 11, 2020 · 1 comment
Open

Make php.ini more granular #6

freephile opened this issue May 11, 2020 · 1 comment

Comments

@freephile
Copy link
Owner

Environment

  • Machine or Virtual Machine details: All
  • Operating System: All
  • meza version hash: n/a

Issue details

Certain extensions such as EmailPage or certain environments will assume a working php mail() function without regard to wgSMTP. Therefore, the php.ini file must be configured or else a local MTA / sendmail equivalent like Postfix configured. Currently the php.ini file is templated without regard to mail settings. And it is re-constructed on every deploy - destroying any local customizations.

Solutions

  1. Make the role controllable with a tag (brittle)
  2. Check for existence of php.ini file and do not overwrite (not good for eventual upgrades / changes)
  3. Make file changes more granular (block in file / line in file)
@freephile
Copy link
Owner Author

Another example:
upload_max_filesize = 5M in php.ini
needs to be templated in parallel with
$wgUploadSizeWarning and $wgMaxUploadSize in LocalSettings.php (or override.php)
AND
client_max_body_size 0; in nginx.conf Setting size to 0 disables checking of client request body size. (default is 1m)
AND
LimitRequestBody 5000000 in apache.conf (5M)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant