Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the target collection/wallet #219

Open
michaelk83 opened this issue Sep 7, 2022 · 1 comment
Open

Allow specifying the target collection/wallet #219

michaelk83 opened this issue Sep 7, 2022 · 1 comment

Comments

@michaelk83
Copy link

Summary

It should be possible to override the target collection or wallet on backends where this is possible, using a new pair of methods Job::setCollection() and Job::getCollection(). On backends where this is not possible, the setting would be ignored. If not set, default to the collection or wallet that is used currently.

Context

This is needed for client applications that may want to store their passwords separately from the rest.
See KDE bugs 228308 and 172523.

Suggested Implementation

  • With libsecret: if set, pass the set collection name to secret_password_store_fn(), otherwise pass SECRET_COLLECTION_DEFAULT as now.
  • With KWallet: if set, call open() with the set name, otherwise call networkWallet() first (as now) to determine the default wallet name.
@michaelk83
Copy link
Author

It could also be useful to have an environment variable for this, so that the end user can force a client application to use a specific collection of their choice (inspired by keepassxreboot/keepassxc#8517 (comment) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant