Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure logical and consistent groupings of cheats in Vm.sol #463

Closed
mds1 opened this issue Sep 29, 2023 · 2 comments · Fixed by #464
Closed

chore: ensure logical and consistent groupings of cheats in Vm.sol #463

mds1 opened this issue Sep 29, 2023 · 2 comments · Fixed by #464

Comments

@mds1
Copy link
Collaborator

mds1 commented Sep 29, 2023

Ref #459

In general, Vm.sol is grouped logically (e.g. all filesystem cheats in one place), but we should:

  1. Make sure all groupings are correct and fix any out-of-place cheats
  2. Add comments to more clearly separate sections so it's more clear
@ruvaag
Copy link
Contributor

ruvaag commented Sep 30, 2023

Following up from the referenced issue, I can take this up

@mds1
Copy link
Collaborator Author

mds1 commented Oct 1, 2023

Thanks @ruvaag, though I already opened a PR for this in #464 :)

@mds1 mds1 closed this as completed in #464 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants