Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Via-IR Compilation tests do not provide confident results #450

Closed
sambacha opened this issue Sep 3, 2023 · 2 comments
Closed

Via-IR Compilation tests do not provide confident results #450

sambacha opened this issue Sep 3, 2023 · 2 comments

Comments

@sambacha
Copy link
Contributor

sambacha commented Sep 3, 2023

forge-std/.github/workflows/ci.yml

Line 87 in 1d9650e

# via-ir compilation time checks.

The forge version being used is inconsistent, let alone not having different yul.OptimizerSteps defined per compilation.

Time series data should be persisted at least to offer some historical comparison at the most naive level.
@mds1
Copy link
Collaborator

mds1 commented Sep 5, 2023 •
edited
Loading

Can you expand on the suggestions here? I don't quite follow.

The via-ir checks in CI are sanity checks to avoid introducing changes that cause via-ir compilation time to blow up, ref #321 and #207, which was the motivation for introducing them

@sambacha
Copy link
Contributor Author

Can you expand on the suggestions here? I don't quite follow.

The via-ir checks in CI are sanity checks to avoid introducing changes that cause via-ir compilation time to blow up, ref #321 and #207, which was the motivation for introducing them

This is closed by #526 and #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mds1 @sambacha