Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-9127: Add the unique ticket code into the downlad CSV file #9133

Merged
merged 4 commits into from Mar 25, 2024
Merged

fix-9127: Add the unique ticket code into the downlad CSV file #9133

merged 4 commits into from Mar 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2024

Fixes #9127

Short description of what this resolves:

  • Add the unique ticket code into the downlad CSV file

Changes proposed in this pull request:

  • Add the unique ticket code into the downlad CSV file

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@ghost ghost marked this pull request as ready for review March 23, 2024 02:41
@ghost ghost requested review from mariobehling, norbusan, marcoag and cweitat March 23, 2024 02:41
@ghost
Copy link
Author

ghost commented Mar 25, 2024

This PR flow solution:

  • Revert the last PR and add back the unique number at the end

Unique number: str(binascii.b2a_hex(os.urandom(3)), 'utf-8')
For example: 0c6a220b-0aba-43f4-a454-f9018ef9e571-5gt35s

norbusan
norbusan approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norbusan norbusan merged commit 2d8025e into fossasia:development Mar 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling Awaiting requested review from mariobehling

@marcoag marcoag Awaiting requested review from marcoag

@cweitat cweitat Awaiting requested review from cweitat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the unique ticket code into the downlad CSV file
1 participant
@norbusan