Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile navbar bug #9177 #9179

Open
wants to merge 19 commits into
base: development
Choose a base branch
from
Open

Conversation

Darkboy17
Copy link

Fixes #9177

Short description of what this resolves:

The mobile navbar which shifts content in x axis rather than overlapping on it now overlays above the content with no more x-axis content shift happening.

Changes proposed in this pull request:

  • Fixes Mobile navbar bug #9177 : by applying a CSS class called "overlay" which seems to be coming from Semantic UI, a popular front-end framework.
  • Changes have been made in a file called side-bar.hbs under /components
  • The first line of code is where the change was made.
  • Screenshot of the fix
    Screenshot 2024-01-28 at 15-57-42 eventyay

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

weblate and others added 19 commits August 18, 2023 02:21
Currently translated at 99.9% (2552 of 2554 strings)

Translation: Open Event/Open Event Frontend
Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/

Co-authored-by: Mario Behling <[email protected]>
* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

* fix css

* fix UI

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* avoid using css inline

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* fix-9082
language dropdown not showing up

* fix-9082
language dropdown not showing up

---------

Co-authored-by: Khang On - TMA <[email protected]>
Co-authored-by: ntthitrinh <[email protected]>
…ng filtered page (fossasia#9145)

* fix-7016: Link redirect of current day results in user forward to wrong filtered page

* fix-7016: Link redirect of current day results in user forward to wrong filtered page
* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

* fix css

* fix UI

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* avoid using css inline

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* fix-9082
language dropdown not showing up

* fix-9082
language dropdown not showing up

* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

---------

Co-authored-by: nnhathung <[email protected]>
Co-authored-by: Khang On - TMA <[email protected]>
Co-authored-by: ntthitrinh <[email protected]>
…ossasia#9115)

* fix-9080: There was no result for searching with Ticket price 0.0

* fix-9080: There was no result for searching with Ticket price 0.0

---------

Co-authored-by: Khang On - TMA <[email protected]>
…ttendees page (fossasia#9078)

* fix-9076: Cannot show all entries when selecting 'Show All' in View Attendees page

* fix-9076: Cannot show all entries when selecting 'Show All' in View Attendees page

* fix-9076: Cannot show all entries when selecting 'Show All' in View Attendees page

---------

Co-authored-by: Khang On - TMA <[email protected]>
fossasia#9157)

* fix-9154: [Badge Wizard] Showing <a> tag in custom field when organizer tries to add custom question to badge

* fix-9154: [Badge Wizard] Showing <a> tag in custom field when organizer tries to add custom question to badge
…ssasia#9150)

* feature-9020: Filter options for orders and attendees not working

* feature-9020: Filter options for orders and attendees not working

* feature-9020: Filter options for orders and attendees not working

* feature-9020: Filter options for orders and attendees not working

* feature-9020: Fix UI filter date

* feature-9020: Fix UI filter date

* feature-9020: Fix UI filter date at the order

* feature-9020: Filter options for orders and attendees not working

---------

Co-authored-by: odkhang <[email protected]>
Co-authored-by: Khang On - TMA <[email protected]>
* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

* feature-9125: Fix top menu for mobile screens

---------

Co-authored-by: ntthitrinh <[email protected]>
…9159)

* fix-9127: Top align table content on manage event dashboard

* fix-9127: Top align table content on manage event dashboard
* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Add option to tag attendees

* feature-8684: Merge code development
…n full (fossasia#9160)

* fix-9140: The value of the status dropdown list cannot be displayed in full

* fix-9140: The value of the status dropdown list cannot be displayed in full
* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

* fix css

* fix UI

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* avoid using css inline

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* fix-9082
language dropdown not showing up

* fix-9082
language dropdown not showing up

* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

---------

Co-authored-by: nnhathung <[email protected]>
Co-authored-by: Khang On - TMA <[email protected]>
Co-authored-by: ntthitrinh <[email protected]>
* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

* fix css

* fix UI

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* fix missing header

* avoid using css inline

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* feature-9082: Fix css dropdown side panel

* fix-9082
language dropdown not showing up

* fix-9082
language dropdown not showing up

* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

* feature-9082: Enhance language dropdown button

---------

Co-authored-by: nnhathung <[email protected]>
Co-authored-by: Khang On - TMA <[email protected]>
Co-authored-by: ntthitrinh <[email protected]>
Currently translated at 100.0% (2554 of 2554 strings)

Translation: Open Event/Open Event Frontend
Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/

Co-authored-by: Kristoffer Grundström <[email protected]>
* Translated using Weblate (Swedish)

Currently translated at 100.0% (2554 of 2554 strings)

Translation: Open Event/Open Event Frontend
Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/

* Translated using Weblate (Swedish)

Currently translated at 99.9% (2552 of 2554 strings)

Translation: Open Event/Open Event Frontend
Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/sv/

* Translated using Weblate (Spanish)

Currently translated at 100.0% (2554 of 2554 strings)

Translation: Open Event/Open Event Frontend
Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/es/

* Translated using Weblate (Polish)

Currently translated at 100.0% (2554 of 2554 strings)

Translation: Open Event/Open Event Frontend
Translate-URL: https://hosted.weblate.org/projects/open-event/frontend/pl/

---------

Co-authored-by: Kristoffer Grundström <[email protected]>
Co-authored-by: gallegonovato <[email protected]>
Co-authored-by: Eryk Michalak <[email protected]>
Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ❌ Failed (Inspect) Jan 28, 2024 10:37am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile navbar bug
5 participants