Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving Badges doesn't work #1125

Open
Derpumu opened this issue Dec 28, 2024 · 5 comments
Open

Saving Badges doesn't work #1125

Derpumu opened this issue Dec 28, 2024 · 5 comments
Labels

Comments

@Derpumu
Copy link

Derpumu commented Dec 28, 2024

Steps to reproduce:

  • start the app
  • Hamburger menu - create badges
  • create something
  • hit the save button
    Expected behavior: some sort of feedback, and the saved badge appears under "saved badges" in the menu
    Actual behavior: no feedback, just back to editing the badge, nothing to see under "saved badges"

Saving cliparts works.

OS: Android 14, Samsung Galaxy S22
Also observed under Android 13, Pixel 4

@cobordism
Copy link

cobordism commented Dec 28, 2024

can confirm for play store version 1.8.10
On clicking "save badge" the keyboard pops up, but nothing is saved.
App does not have nor ask for permissions to access storage.

meanwhile saving works for me on fdroid version 1.7.0
On clicking "save badge" a dialog opens to enter the file name.
App asked for, and has access to storage.

@adityastic
Copy link
Collaborator

@Derpumu @cobordism can you guys try the latest beta version: https://play.google.com/apps/testing/org.fossasia.badgemagic

@Sherl0ck007
Copy link

Sherl0ck007 commented Jan 2, 2025

@adityastic
Saving now works and files are saved as json files (at least it looks that way when sharing them)
When I updated the app, my previously saved cliparts where gone. Is that expected behaviour for future updates as well?

@adityastic
Copy link
Collaborator

@Jhalakupadhyay might want to look into this

@adityastic
Copy link
Collaborator

@Sherl0ck007 we moved to flutter in the last months and re created the app from scratch. This specific update would use a different schema for saving badges. It should not happen for upcoming updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants