Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for core lightning watchtower TEoS (The Eye of Satoshi) - server and client #543

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add support for core lightning watchtower TEoS (The Eye of Satoshi) - server and client #543

wants to merge 20 commits into from

Conversation

seberm
Copy link
Contributor

@seberm seberm commented Aug 30, 2022 •
edited
Loading

@seberm seberm force-pushed the feature/add-rust-teos branch 16 times, most recently from 98f9500 to e0eae6d Compare September 3, 2022 20:39
@seberm seberm mentioned this pull request Sep 4, 2022
Closed
@seberm seberm force-pushed the feature/add-rust-teos branch 3 times, most recently from bb319fe to 42626b6 Compare September 4, 2022 21:14
mariocynicys
mariocynicys reviewed Sep 6, 2022
View reviewed changes
pkgs/teos/default.nix Outdated Show resolved Hide resolved
@seberm seberm force-pushed the feature/add-rust-teos branch 9 times, most recently from 93ad7ba to 509f3b8 Compare September 8, 2022 10:50
@seberm
Copy link
Contributor Author

seberm commented May 25, 2024

Hello @jonasnick,

He hasn't managed to make a new release so far and suggests to use master instead of the release.

The teos package is now part of nixkpgs upstream. I am not sure if we can use the master branch directly there.

However, if Sergi recommends using the master branch, I can prepare a package overlay at least for nix-bitcoin.

For anyone interested in getting this merged, please test it and feel free to provide a review. I'll be glad to address any issues.

Thanks!

HaosGames
HaosGames reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@HaosGames HaosGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I started testing this now with CLN as a backend and the teos daemon on a separate host with a pruned bitcoind.
Works great so far with minimal configuration.

@HaosGames
Copy link
Contributor

Still running great on my side. I would love to see this in a release.

@sr-gi sr-gi mentioned this pull request Jul 26, 2024
Open
@sr-gi
Copy link

sr-gi commented Jul 29, 2024

I'm planning to cut a release sooner rather than later, which will include all the changes pointed out in the PR description AFAICT. Is there anything else that'd needed?

JosephGoulden
JosephGoulden approved these changes Sep 16, 2024
View reviewed changes
Copy link

@JosephGoulden JosephGoulden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running the watchtower and plugin modules from this PR and its working well.

It would be nice to have a service that automatically registers with the tower and renews the subscription when needed. But we can add that later.

Also I opened a PR to add a flake to TEOS.

@seberm
rust-teos: init at 0.1.2
b901f4e
@seberm
rust-teos: add module
c5356af
@seberm
clightning: add TEoS watchtower plugin
1541cc8
@seberm
teos: add new options and defaults for teos v0.2.0
174124d 
# Conflicts:
#	modules/clightning-plugins/teos-watchtower-plugin.nix
@seberm
teos: fix onion ports to be handled by the nix-bitcoin onion-services…
fd7e178 
… correctly
@seberm
teos: change btc network name to mainnet
e466074
@seberm
teos: improve the docs in example configuration
c47eab6
@seberm
teos: enable tor in teos conditionally
be06246
@seberm
teos: rename the teos-watchtower-plugin to just teos-watchtower
d5ae5a4
@seberm
teos: fix the onionServices condition
e0c5afc
@seberm
teos: just enable onion service for teos, no need to set it public
9e95d94
@seberm
teos: fix the onion services port mapping
a90ced3
@seberm
teos: add documentation watchtower plugin usage in lightning-cli
aa51b19
@seberm
teos: tests: improve tests for teos service and teos-cli
c2bbc7f
@seberm
teos: tests: add tests for cln watchtower plugin
f56346c
@seberm
teos: netns: add possibility of clightning to connect to local teos s…
2ec0b4f 
…ervice
@seberm
teos: final code cleanup
25f4db3
@seberm
nodeinfo: add teos tower ID
92113dd
@seberm
clightning: watchtower: do not hide the tower data directory
b1802c3
@seberm
backups: add teos and teos-watchtower to regular backups
bd3f0d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephGoulden JosephGoulden JosephGoulden approved these changes

@HaosGames HaosGames HaosGames approved these changes

@erikarvstedt erikarvstedt Awaiting requested review from erikarvstedt

@3cola 3cola Awaiting requested review from 3cola

@mariocynicys mariocynicys Awaiting requested review from mariocynicys

@mmilata mmilata Awaiting requested review from mmilata

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CLN Watchtower
9 participants
@seberm @3cola @jonasnick @HaosGames @sr-gi @mmilata @JosephGoulden @erikarvstedt @mariocynicys