Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convolution should never break the browser #59

Open
OAGr opened this issue Jul 6, 2020 · 1 comment
Open

Convolution should never break the browser #59

OAGr opened this issue Jul 6, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@OAGr
Copy link
Contributor

OAGr commented Jul 6, 2020

When I enter,
normal(5,2) * normal(5,2)

And have "Downsample To" as blank, it crashes. This shouldn't happen.

image

@OAGr OAGr added the bug Something isn't working label Jul 6, 2020
@skosch
Copy link
Collaborator

skosch commented Jul 12, 2020

Leaving that field blank currently sets the sampleCount to 10000 (see this line in DistBuilder.re):

~recommendedLength=options.downsampleTo |> E.O.default(10000),

This seems to be the downfall of convolution, and ultimately also sampling. I think we really have to come up with a reasonable strategy for how many sample points to use depending on the situation.

One thing I think would be REALLY impressive, some day in the future, would be a sample count that increases progressively (both for rendering and sampling) until some sort of equilibrium is reached. Ideally offloaded to webworkers. Sort of like what the Cycles engine does in Blender (video). (That would probably also require switching to non-SVG rendering, but apparently d3+canvas is an option nowadays, and https://d3fc.io even supports WebGL.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants