Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize combineShapesContinuousContinuous #50

Open
3 tasks
skosch opened this issue Jun 30, 2020 · 1 comment
Open
3 tasks

Optimize combineShapesContinuousContinuous #50

skosch opened this issue Jun 30, 2020 · 1 comment

Comments

@skosch
Copy link
Collaborator

skosch commented Jun 30, 2020

The continuous/continuous case of algebraic combination (aka "convolution") is currently really slow. There are several opportunities for quality and speedup. At a minimum:

  • Intelligent downsampling before starting the convolution
  • Better target points (via some sort of clustering or binning?)
  • Use of triangular kernels for adding up the results, and a tree structure (B-tree?) for the target nodes. The current implementation uses Gaussian kernels and is O(M × N) sloooow.
@OAGr
Copy link
Contributor

OAGr commented Jul 6, 2020

I think I feel fairly uncomfortable about convolution and the challenges it seems to bring. It seems like it introduces a fair number of edge cases, and it's not obviously it's more worthy of investment than sampling at these points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants