Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The eslint.nodePath value in .vscode/settings.json does not get updated #424

Open
trevor-bliss opened this issue Jul 6, 2021 · 1 comment
Labels
type:bug Creates internal bug with Git2Gus

Comments

@trevor-bliss
Copy link

Summary

The eslint.nodePath value in .vscode/settings.json does not get updated with the highest local version of eslint-tool. This is for core workspaces in ui-foo-components projects.

Most likely this is because the merging logic of the settings.json intentionally does not override existing values.

Steps To Reproduce:

  1. Do a full core build.
  2. Run the ESLint corecli command.
  3. Load VS Code with the root of the project at a specific project (e.g., ui-force-components).
  4. Check the value of eslint.nodePath.

Expected result

The eslint.nodePath value should point to the highest local version of eslint-tool on my local machine.

Actual result

The eslint.nodePath is never updated once initially set.

Additional information

VS Code Version: 1.57.1

SFDX CLI Version:

OS and version: Mac 10.14.6

@xyc xyc added the BUG P3 label Jul 6, 2021
@xyc
Copy link
Contributor

xyc commented Jul 7, 2021

We should probably allow overwriting at least the key eslint.nodePath. Workaround for this is: set eslint.nodePath in .vscode/settings.json manually to the path to the highest version in ~/tools/eslint-tools, or delete the eslint.nodePath entry and it will get reset.

@randi274 randi274 added type:bug Creates internal bug with Git2Gus and removed BUG P3 labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Creates internal bug with Git2Gus
Projects
None yet
Development

No branches or pull requests

3 participants