Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Upate / tweaks to the outlier flattening in AP fitting #217

Open
TomDonoghue opened this issue Sep 28, 2021 · 0 comments
Open

[ENH] - Upate / tweaks to the outlier flattening in AP fitting #217

TomDonoghue opened this issue Sep 28, 2021 · 0 comments
Labels
idea / discussion A potential idea to consider / discuss.

Comments

@TomDonoghue
Copy link
Member

During reviews for the Developmental Demo paper, we got some feedback about how the current approach for flattening outliers in the aperiodic fitting might be sub-optimal for some development data.

In their suggested edit, the outlier flattening in _robust_ap_fit was updated to:

if min(flatspec) < 0:
    flatspec -= min(flatspec)

Correspondingly, the fit function was edited to add the following line to line 458:
self._spectrum_flat[self._spectrum_flat < 0] = 0

This is something to explore and we should build in this customization to the next release.

@TomDonoghue TomDonoghue added the idea / discussion A potential idea to consider / discuss. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea / discussion A potential idea to consider / discuss.
Projects
None yet
Development

No branches or pull requests

1 participant