Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com.google.fonts/check/missing_small_caps_glyphs] Check passes for font missing Cyrillic small caps #4713

Open
yanone opened this issue May 10, 2024 · 1 comment · May be fixed by #4721
Open

[com.google.fonts/check/missing_small_caps_glyphs] Check passes for font missing Cyrillic small caps #4713

yanone opened this issue May 10, 2024 · 1 comment · May be fixed by #4721
Assignees
@yanone
Labels
Check improvement proposal

Comments

@yanone
Copy link
Collaborator

yanone commented May 10, 2024

Bitter has no small caps for Cyrillic, so I would have expected this check to produce a FAIL, but it passes. I haven't investigated further yet.

I propose to fix this, so I'm assigning myself.
@yanone yanone self-assigned this May 10, 2024
@yanone
Copy link
Collaborator Author

yanone commented May 10, 2024

Actually, this should have also been reported by shaperglot. Will investigate that, too.

@yanone yanone linked a pull request May 15, 2024 that will close this issue
Draft
3 tasks
felipesanches pushed a commit that referenced this issue Sep 9, 2024
@yanone @felipesanches
Update 'missing_small_caps_glyphs' check:
0c1f34b 
On the Universal profile:
  - missing_small_caps_glyphs: Rewrote it from scratch, marked it as **experimental**.

(issue #4713)
felipesanches pushed a commit that referenced this issue Sep 9, 2024
@yanone @felipesanches
Update 'missing_small_caps_glyphs' check:
3bd98b3 
On the Universal profile:
  - missing_small_caps_glyphs: Rewrote it from scratch, marked it as **experimental**.

(issue #4713)
felipesanches pushed a commit that referenced this issue Sep 9, 2024
@yanone @felipesanches
Update 'missing_small_caps_glyphs' check:
b54cfe9 
On the Universal profile:
  - missing_small_caps_glyphs: Rewrote it from scratch, marked it as **experimental**.

(issue #4713)
felipesanches pushed a commit that referenced this issue Sep 10, 2024
@yanone @felipesanches
Update 'missing_small_caps_glyphs' check:
5945364 
On the Universal profile:
  - missing_small_caps_glyphs: Rewrote it from scratch, marked it as **experimental**.

(issue #4713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanone yanone

Labels
Check improvement proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrote small_caps check (and a minor case_mapping improvement) fonttools/fontbakery
1 participant
@yanone