You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Json serialization of timestamps has some issues (they're serialized as objects and not strings, as per protojson format) and @harjotgill created a workaround for that, which converts all timestamp fields manually.
An alternative workaround would be to utilize binary serialization instead of json. We can do it because metricsprocessor accepts aperture.check_response as json but also as base64-encoded protowire. This could even result in a performance improvement as a side-effect.
Note: This requires swapping out the generator, as the current one doesn't provide anything like serializeBinary / encode, etc.
Note: If this requires some more effort, let's stay with current workaround.
The text was updated successfully, but these errors were encountered:
Json serialization of timestamps has some issues (they're serialized as objects and not strings, as per protojson format) and @harjotgill created a workaround for that, which converts all timestamp fields manually.
aperture/sdks/aperture-js/sdk/flow.ts
Lines 78 to 108 in bce96d9
An alternative workaround would be to utilize binary serialization instead of json. We can do it because metricsprocessor accepts aperture.check_response as json but also as base64-encoded protowire. This could even result in a performance improvement as a side-effect.
Note: This requires swapping out the generator, as the current one doesn't provide anything like
serializeBinary
/encode
, etc.Note: If this requires some more effort, let's stay with current workaround.
The text was updated successfully, but these errors were encountered: