Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Requirements to move back to go-git/go-git #397

Open
3 tasks done
pjbgf opened this issue Nov 9, 2022 · 1 comment
Open
3 tasks done

git: Requirements to move back to go-git/go-git #397

pjbgf opened this issue Nov 9, 2022 · 1 comment
Labels
area/git Git and SSH related issues and pull requests

Comments

@pjbgf
Copy link
Member

pjbgf commented Nov 9, 2022

The go-git/go-git dependency has recently been replaced with fluxcd/go-git`. In order to be able to move back to the upstream project, we need:

Upstream performance improvements

Upstream behaviour changes

@pjbgf pjbgf added the area/git Git and SSH related issues and pull requests label Nov 9, 2022
@pjbgf pjbgf moved this to In Progress in Maintainers' Focus Nov 16, 2022
codablock added a commit to kluctl/kluctl that referenced this issue Dec 13, 2022
See fluxcd/pkg#397, especially in regard to
skeema/knownhosts breaking compatibility
@pjbgf
Copy link
Member Author

pjbgf commented Mar 5, 2023

Runnign the tests using upstream go-git version (v5.6.0) breaks two tests:

  1. Test_SOCKS5_proxy
  2. Test_HTTP_proxy/env_var:_HTTPS_PROXY

The former is fixed by go-git/go-git#655. The latter will require the upstreaming of fluxcd/go-git#9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git and SSH related issues and pull requests
Projects
Status: In Progress
Development

No branches or pull requests

1 participant