-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: reject configurations that don't match rank 0 #6391
Comments
Hmm, that's definitely possible to check at connect time, although two concerns:
|
At connection time, this is probably correct. However, for a running instance with a running connection, we use "mismatched" configurations to test prologs/epilogs (this is somewhat related to #5531). Start a job across a bunch of nodes, then mess with the imp to test out a new prolog/epilog. Just something to keep in mind. |
Re: 1 - Are there things that aren't sensitive to being different and where you might want them to be so, beyond test cases? It definitely adds some complexity if we'd have to create a list of what does and doesn't matter.
Oh, yes, I'm just thinking in terms of connection time. Constantly checking the config seems very out of scope. |
Sorry I misunderstood! Just wanted to throw that sort of niche edge case in there. |
It's a good point, taken as written you can totally read it as "if the config changes, drop the node" which is also a much more complicated issue. |
Reference #6389
My understanding is that there's no situation where a mismatched configuration would be desirable. If that's true, it'd be useful to outright reject connections from nodes with a mismatched configuration, preferably with an error message indicating what setting doesn't match. Similar to the way version mismatches cause a rejection and no further processing, just to prevent downstream issues.
The text was updated successfully, but these errors were encountered: