Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize button misplaced #948

Closed
znakeeye opened this issue Jun 4, 2021 · 6 comments
Closed

Minimize button misplaced #948

znakeeye opened this issue Jun 4, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@znakeeye
Copy link

znakeeye commented Jun 4, 2021

Can we restyle it to get Office 2016 look?

image

The current placement is problematic when you add multiple toolbar items. The minimize button then ends up near the center. It seems hard to re-template the problematic XAML:

<StackPanel HorizontalAlignment="Right"
            Grid.Column="3"
            Orientation="Horizontal"
            Margin="0,0,0,1">
    <Fluent:ToggleButton x:Name="PART_MinimizeButton"
                         Margin="0"
                         Width="22"
                         Height="22"
                         Size="Small"
                         Style="{DynamicResource RibbonTabControlToggleButtonStyle}"
                         IsChecked="{Binding Path=IsMinimized, Mode=TwoWay, RelativeSource={RelativeSource TemplatedParent}}"
                         Visibility="{TemplateBinding CanMinimize, Converter={StaticResource boolToVisibilityConverter}}" />

    <StackPanel x:Name="PART_ToolbarPanel"
                Visibility="{Binding IsToolBarVisible, RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource boolToVisibilityConverter}}"
                Orientation="Horizontal" />
</StackPanel>

Environment

  • Fluent.Ribbon v7.0.0
  • Windows 10
  • .NET Framework 4.8
@batzen batzen self-assigned this Jun 14, 2021
@batzen batzen added the Styles label Jun 14, 2021
@batzen
Copy link
Member

batzen commented Jun 14, 2021

@znakeeye As a first step to improve consistency across applications i will move the minimize button to right hand side of the toolbar.

@batzen batzen added this to the 10.0 milestone May 20, 2022
@batzen
Copy link
Member

batzen commented Jun 11, 2022

@znakeeye I thought about this again and think the current solution (having it moved to the right side) looks and feels better than the Office version where the button is shown/hidden depending on state.
What do you think?

@znakeeye
Copy link
Author

Do you have a screenshot? Don't have my ribbon app at hand :D

@batzen
Copy link
Member

batzen commented Jun 12, 2022

image
image
image

@znakeeye
Copy link
Author

I agree with you. I actually "struggled" with this in Office 365 the other day. Hiding a button is not ideal 🙂

@batzen
Copy link
Member

batzen commented Jun 16, 2022

So can we close this or do you think there should be other changes made to the minimize button?

batzen added a commit that referenced this issue Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants