Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'data' property is optional in *List API #22

Open
trzcina opened this issue Jun 10, 2024 · 0 comments
Open

The 'data' property is optional in *List API #22

trzcina opened this issue Jun 10, 2024 · 0 comments

Comments

@trzcina
Copy link
Contributor

trzcina commented Jun 10, 2024

I think this value should be always present, and should not be optional

export interface PageList {
   //  ...
    current_page: number ;
    /**
     * 
     * @type {Array<Page>}
     * @memberof PageList
     */

    data?: Array<Page> ; // <------- here
}

it causes unnecessary checks

  return pages.data?.map((page) => ({  // <--- question mark
    slug: page.slug,
  })) ?? [];

Can you mark the data property as required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant