Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gerrit-queue will attempt to submit changes that are not ready #14

Open
tazjin opened this issue Sep 17, 2022 · 1 comment
Open

gerrit-queue will attempt to submit changes that are not ready #14

tazjin opened this issue Sep 17, 2022 · 1 comment

Comments

@tazjin
Copy link
Collaborator

tazjin commented Sep 17, 2022

Sometimes, gerrit-queue will take a random change out of the middle of a chain that's still in-progress, rebase it onto HEAD and try to submit it (which in the case of TVL will often fail, as the build might not succeed due to the parents in the chain missing and then blocking submit).

We don't have a way to reproduce this, it just occasionally happens. Notably, when it happens it seems to occur in clusters - e.g. multiple of these incidents on the same day.

@flokli
Copy link
Owner

flokli commented Sep 17, 2022

Do you have logs for one of these incidents? It might help to figure out what code paths are active while this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants