Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Android app crashes #1308

Closed
1 task
kalekad opened this issue Dec 31, 2022 · 18 comments
Closed
1 task

The Android app crashes #1308

kalekad opened this issue Dec 31, 2022 · 18 comments
Labels

Comments

@kalekad
Copy link

kalekad commented Dec 31, 2022

Which version of floccus are you using?

v4.18.0

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Samsung, LineageOS 19.1(Android 12L)

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

application crashes when selecting a bookmark

Expected Behavior

To Reproduce

Debug log provided

  • I have provided a debug log file
@kalekad kalekad added the bug label Dec 31, 2022
@kalekad
Copy link
Author

kalekad commented Dec 31, 2022

The application crashes when I select a bookmark, but the menu appears in which browser I want to open the bookmark, I select the browser and the bookmark is loaded.

@kalekad
Copy link
Author

kalekad commented Dec 31, 2022

-ad: When I reopen an already opened application in the background, I don't go back to the folder where I was, but the application loads the base folder.

@kalekad
Copy link
Author

kalekad commented Dec 31, 2022

-ad: In the browser, I share a bookmark to the app, the bookmark save menu appears, I don't save the bookmark, but I click the arrow in the top left corner, go back to the browser and back to Floccus, and the previously rejected bookmark shows up for saving.

@marcelklehr
Copy link
Member

marcelklehr commented Dec 31, 2022

The application crashes when I select a bookmark, but the menu appears in which browser I want to open the bookmark, I select the browser and the bookmark is loaded.

I cannot reproduce this.

@marcelklehr
Copy link
Member

When I reopen an already opened application in the background, I don't go back to the folder where I was, but the application loads the base folder.

I cannot reproduce this. For me it works.

@marcelklehr
Copy link
Member

In the browser, I share a bookmark to the app, the bookmark save menu appears, I don't save the bookmark, but I click the arrow in the top left corner, go back to the browser and back to Floccus, and the previously rejected bookmark shows up for saving.

I can only reproduce this when not tapping the back button in the save menu but switching to the browser directly and then resharing to floccus. I don't believe this can be fixed, though.

@technopagan
Copy link

+1'ing the crashing on Lineageos 19.1 + WebDav:

During account setup, the app constantly resets itself when losing focus (e.g. when I look up my WebDav password) so that I had to write everything down beforehand and do the account setup without changing app focus.

After the WebDav account was finally set up, I tried importing an HTML bookmarks file. This also makes the app crash immediately.

@heapifyman
Copy link
Contributor

heapifyman commented Jan 8, 2023

I experience the same behaviour as @kalekad. The app seems to be crashing or re-initializing after selecting a bookmark. Examples:

Select bookmark directly

  1. Open floccus, navigate into a bookmark folder, and select any of the bookmarks to open it in your browser.
  2. Bookmark opens in browser.
  3. Switch back from browser to floccus.
  4. Floccus displays root folder instead of the folder you navigated to in step 1.

Select bookmark from search results

  1. Open floccus, search for a bookmark, and select any of the search results to open it in your browser.
  2. Bookmark opens in browser.
  3. Switch back from browser to floccus.
  4. Floccus displays root folder instead of the search results from step 1.

In step 2, when the bookmark is already opened in the browser I often get a popup from Android saying: "floccus bookmark sync keeps stopping", with options to stop the app or view app information. (I assume that is an indicator that the app crashed?)

This started happening only after updating to version 4.18.0.

Downgrading to 4.17.1 resolves the issue.

I am using a Google Pixel 6 with Android 13 (patch level January 2023). Floccus was installed from f-droid store.

I am synching bookmarks to a nextcloud instance. After updating to v4.18.0 I changed the sync interval to 10 minutes (from the default 15 minutes).

Do I need to disable battery optimisation for floccus so that it can run in the background?

@KevinCFechtel
Copy link

KevinCFechtel commented Jan 8, 2023

I experienced also the same behavior with resetting the app when loosing focus.
Also i can repeatly crash the app by adding a Bookmark with empty Link (only with a title) to the root folder.
The only way to get the app back working is to delete all data (which means i need to readd the account which is a paine with the resetting when losing focus bug).
I am using a Samsung Galaxy S20 FE with Android 13 patchlevel December 2022
App Version is 4.18.0 from googleplay

@marcelklehr
Copy link
Member

The only thing I can reproduce is the broken state after adding a bookmark without a link. I can fix that.

The crashing / resetting may be due to capacitor v4. Hopefully they have a fix for that

@marcelklehr
Copy link
Member

Could you may try to get the log after a crash, if you have a bit of android experience?

@KevinCFechtel
Copy link

I will try to get the logs with logcat tomorrow.

@KevinCFechtel
Copy link

So, here are two log files.
One with the crash after inserting an empty link (with starting the app in the broken state).
One with resetting the application when loosing focus.
Hope this helps.
floccus_empty_link.log
floccus_loosing_focus.log

@heapifyman
Copy link
Contributor

java.lang.RuntimeException: Unable to create service de.appplant.cordova.plugin.background.ForegroundService: java.lang.IllegalArgumentException: org.handmadeideas.floccus: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.

Probably this issue: katzer/cordova-plugin-background-mode#574 ?

There's an open PR with a fix: katzer/cordova-plugin-background-mode#571

But the project seems to be unmaintained - no commit for over 3 years.

@heapifyman
Copy link
Contributor

@marcelklehr do you have an ETA for a new release that contains the fix?

@marcelklehr
Copy link
Member

@heapifyman Should be out now on Google Play

@heapifyman
Copy link
Contributor

And on f-droid, too :) thanks

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

5 participants