Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout submodules recursively in GitHub actions #22

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Checkout submodules recursively in GitHub actions #22

merged 2 commits into from
Jul 31, 2023

Conversation

jtraglia
Copy link
Collaborator

We need to initialize submodules recursively now. Otherwise the deploy step will fail:

avalonche
avalonche approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to update the other workflows with submodules: recursive too

@jtraglia
Copy link
Collaborator Author

Ah yeah, good call. Will do.

@jtraglia
Copy link
Collaborator Author

Only needed to update the release action. All GitHub actions do a recursive checkout now.

@jtraglia jtraglia changed the title Checkout submodules recursively in deploy Checkout submodules recursively in GitHub actions Jul 31, 2023
@jtraglia jtraglia merged commit 5400891 into flashbots:main Jul 31, 2023
2 checks passed
@jtraglia jtraglia deleted the deploy-recursive branch July 31, 2023 22:41
@jtraglia jtraglia mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avalonche avalonche avalonche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @avalonche