From 0f9c33080c5b9aac04132f92de9b98ce34df4fb1 Mon Sep 17 00:00:00 2001 From: evalir Date: Thu, 14 Nov 2024 12:14:27 +0100 Subject: [PATCH] chore(`reth-rbuilder`): remove unnecesary tracing init (#246) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## 📝 Summary Removes the tracing initialization when spawning an `rbuilder` handle. ## 💡 Motivation and Context Reth indeed boots up tracing itself, so this is indeed unnecessary. ## ✅ I have completed the following steps: * [x] Run `make lint` * [x] Run `make test` * [ ] Added tests (if applicable) --- crates/reth-rbuilder/src/main.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/crates/reth-rbuilder/src/main.rs b/crates/reth-rbuilder/src/main.rs index 2c861c1b..9aac13bf 100644 --- a/crates/reth-rbuilder/src/main.rs +++ b/crates/reth-rbuilder/src/main.rs @@ -96,10 +96,6 @@ where let result = async { let config: Config = load_config_toml_and_env(config_path)?; - // TODO: Check removing this is OK. It seems reth already sets up the global tracing - // subscriber, so this fails - // config.base_config.setup_tracing_subscriber().expect("Failed to set up rbuilder tracing subscriber"); - // Spawn redacted server that is safe for tdx builders to expose telemetry::servers::redacted::spawn( config.base_config().redacted_telemetry_server_address(),