Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull SchemaDirectory out of generate command to make available across tools #830

Open
willosborne opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels

Comments

@willosborne
Copy link
Member

Feature Request

Description of Problem:

Currently many commands use their own mechanisms to load schemas.
SchemaDirectory is the most flexible of these and is only used by generate.
See #790 for more details on the refactor.

This issue is just to refactor the SchemaDirectory to be at a higher level. Smaller issues will then adapt the different commands to use it for loading schemas

Potential Solutions:

Pull out from generate to top level within shared.

Identify any generate-specific logic within the class.

@willosborne willosborne self-assigned this Jan 23, 2025
willosborne added a commit that referenced this issue Jan 24, 2025
* Move schema directory to top level module and fix tests

* Move utils that aren't shared out of utils file

* Rethrow error rather than calling process.exit(1) in schema dir

* lint

* Improve error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant