Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Onboarding Checklist #789

Open
rocketstack-matt opened this issue Jan 10, 2025 · 2 comments
Open

Project Onboarding Checklist #789

rocketstack-matt opened this issue Jan 10, 2025 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rocketstack-matt
Copy link
Member

Feature Request

Description of Problem:

Whilst adding the visualizer project into the monorepo, we thought of numerous tasks that should have been completed post merge, such as adding the project into the workspace, readme, codeowners, etc.

Solution:

We should create a new issue type for adding projects with a checklist for contributors to complete.

@rocketstack-matt rocketstack-matt added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Jan 10, 2025
@Thels
Copy link
Member

Thels commented Jan 14, 2025

  • .github/CODEOWNERS is updated to add your new module.
  • Ensure workflow actions are added to .github/workflows that build/verify the module for any PR's with it in its blast radius. For example if your module depends on shared it should trigger build/tests on shared changes.
  • README.md updated with new module and owners. Refer to the URL
  • If it's a typescript module - add into the root level package.json under workspaces: so that we can hoist shared dependencies and allow root level installs/builds etc.
  • New module should have a README.md documenting what the module does - how to develop for it and any other sort of contribution guidelines.
  • If the new module requires a new label for PR clarity ( PR Clarity - Labelling #783 ) - add this into .github/labeler.yml and if this is a new label please manually create it on GitHub.

@Thels
Copy link
Member

Thels commented Jan 16, 2025

Assigning to myself - will get this added onto a new issue type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants