Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product type field to Product #1374

Open
Tracked by #1489 ...
mistryvinay opened this issue Sep 24, 2024 · 3 comments
Open
Tracked by #1489 ...

Add product type field to Product #1374

mistryvinay opened this issue Sep 24, 2024 · 3 comments
Labels
enhancement New feature or request Use cases Use cases Discussion Group

Comments

@mistryvinay
Copy link
Contributor

mistryvinay commented Sep 24, 2024

Enhancement Request

Use Case:

Add field to support further descriptive information of a product type.

Example:

{
    "type": "fdc3.trade",
    "name": "FLY vs 530",
    "notes": "New Trade",
    "product": {
        "type": "fdc3.product",
        "id": {
            "productId": "Sep24 350/400/450",
            "type": "CALL"
        },
        "instrument": {
            "type": "fdc3.instrument",
            "id": {
                "ticker": "QQQ US"
            }
        }
    }
}

Workflow Description

Ability to send supporting information around a product type.

Comments and feedback welcomed.

@mistryvinay mistryvinay added the enhancement New feature or request label Sep 24, 2024
@mistryvinay mistryvinay changed the title Add product type field to Product type Add product type field to Product Sep 24, 2024
@VedPrakashJha-FMR
Copy link

Hi @mistryvinay - I would like to contribute to this issue. Please let me know the next steps.
PS: I'm a new member and I would love to contribute/participate.

@kriswest
Copy link
Contributor

Hi @VedPrakashJha-FMR, not sure if you've spoken to @mistryvinay yet, but if not I highly recommend joining the next meeting of teh Use Cases group on the 7th November (note that you can ask [email protected] to add you to meeting invites so they're on your calendar).

When it comes to context types, that group is the perfect place to discuss additional fields in existing context types, like fdc3.product, to represent info you might need to pass between apps. Regarding this issue, we'll need help defining an enumeration of all possible product types. Thats sounds like a technical contribution to the meeting - however, the use case group is intended to be stakeholder-friendly and it's really the business use cases that we're digging into. What type of products are there that need to be represented? "What additional fields are needed to describe their properties" is then a natural technical question stemming from that.

Finally, anyone can participate outside of a meeting via raising an issue, commenting on that issues or starting a discussion. Either can then be included in a meeting agenda for further discussion.

@mistryvinay
Copy link
Contributor Author

Based on fdc3.rfq context type proposal #1461 .

Updating this fdc3.product schema to follow this structure

{
  "type": "fdc3.product",
  "id": {
    "productId": "SPY-CALLFLYWING+-20241220"
  },
  "instrument": {
    "type": "fdc3.instrument",
    "id": {
      "ticker": "SPY",
      "underlying": {
        "code": "SPY",
        "description": "SPDR S&P 500 ETF TRUST",
        "market": "ETF"
      }
    },
    "details": {
      "description": "SPY CF W+ 20DEC24 580/590/600 1x2x1 r572.99 d13% (PHLX)",
      "structureType": "Call Fly Wing+",
      "exchange": "PHLX",
      "size": {
        "min": 1000,
        "increment": 100,
        "type": "Lots"
      },
      "price": {
        "tick": 0.1,
        "type": "Price"
      },
      "legs": [
        {
          "type": "Call",
          "maturityDate": "2024-12-20",
          "strikePrice": 580,
          "ratioQty": 1,
          "side": "Buy"
        },
        {
          "type": "Call",
          "maturityDate": "2024-12-20",
          "strikePrice": 590,
          "ratioQty": -2,
          "side": "Sell"
        },
        {
          "type": "Call",
          "maturityDate": "2024-12-20",
          "strikePrice": 600,
          "ratioQty": 1,
          "side": "Buy"
        }
      ]
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Use cases Use cases Discussion Group
Projects
None yet
Development

No branches or pull requests

3 participants