Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Spacing Between Instagram Icon and Text in Social Media Links #7887

Open
amit712singhal opened this issue Oct 17, 2024 · 7 comments

Comments

@amit712singhal
Copy link

Is your feature request related to a problem? Please describe.
I'm frustrated when the Instagram icon and text are not properly spaced compared to the other social media icons. The label "Connect on" is inconsistent with the way other platform names (e.g., Facebook, LinkedIn) are displayed, leading to visual inconsistency and a cluttered UI.


Describe the solution you'd like
I would like the text "Connect on" to be replaced with "Instagram" to match the other social media labels, and to have uniform spacing between the Instagram icon and its text, similar to how Facebook, LinkedIn, and Twitter are displayed. This can be achieved by adding margin-left and margin-right to the Instagram icon.


Describe alternatives you've considered
An alternative could be to change all the social media text to include "Connect on" (e.g., "Connect on Facebook"), but this approach would be unnecessarily verbose and might detract from the simplicity of the UI. Another option would be adjusting the font size or adding padding, but these would not address the specific spacing issue.


Additional context
Attached are screenshots before and after the changes, showing how the Instagram icon was initially cramped and how the revised spacing creates a more balanced layout for the social media links.

Before:
Screenshot from 2024-10-17 10-50-53

After:
Screenshot from 2024-10-17 10-51-00

@fineanmol
Copy link
Owner

@amit712singhal Please Star ⭐️ the repo to earn 'hacktober-accepted' label for the event.\nMeanwhile, if you want to work on this issue, please raise a PR, and we will review and merge it.

@amit712singhal
Copy link
Author

Hi @fineanmol, I have opened the PR to fix the above issue. Please assign the issue with label hactoberfest to me and review the PR. Thanks.

@Absk024
Copy link

Absk024 commented Oct 18, 2024

@fineanmol let me handle this one!

@arbazahmed07
Copy link

hey @amit712singhal can you assign this

@amit712singhal
Copy link
Author

@arbazahmed07 I am waiting for my PR to get accepted, the repo is not under me 🥲

@ManeVaishnu
Copy link

ManeVaishnu commented Oct 20, 2024

@fineanmol I have resolved this issue and raised PR

@ManeVaishnu
Copy link

Instagram menu changes #7950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants