Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Improve UITests #16446

Closed
4 of 7 tasks
Lamparter opened this issue Nov 6, 2024 · 4 comments
Closed
4 of 7 tasks

Code Quality: Improve UITests #16446

Lamparter opened this issue Nov 6, 2024 · 4 comments

Comments

@Lamparter
Copy link
Contributor

Lamparter commented Nov 6, 2024

Description

Right now, the UITests app is left in a rather sorry state:

Image

broken sidebar

Image

bad icon

Image

bad taskbar name

Image

homepage is empty

So I'd like to take the effort to make it a little bit better.

Concerned code

tests/Files.App.UITests/

Gains

  • Easier navigation
  • App is more recognisable

Requirements

  • Change app name from Files ui tests app to Files UI Tests
  • Add app logo (here's a quick mockup I made based on the original logo!)
Files UITests
  • Upgrade WinAppSdk to 1.6 (supposedly a bit quicker than Code Quality: WinAppSdk 1.6 #16156 lol)
  • Add homepage
  • Fix sidebar
  • Fix taskbar name
  • Add a code section to each control to see how to implement it (probably going a bit too much into a gallery app than a controls demo)

Comments

I have already made a start at Lamparter:uitests which I'll create a PR for once this I get the go-ahead on this.


Files UI Tests in the taskbar

@0x5bfa
Copy link
Member

0x5bfa commented Nov 7, 2024

broken sidebar

I was going to use ToggleSwitch on the right side of the caption buttons on the top of the window. But I didn't have much time to remake it and also this isn't user-facing, therefore I don't find it should be updated now.

bad icon

I find it cool but maybe we'd like to keep the repo smaller and again it's not user-facing therefore I don't find it good idea. We should improve this project as we update controls.

bad taskbar name

I guess, we can move forward this.

homepage is empty

I was going to add cards for the controls but we don't have as many controls as we can create them on the best layout.

App is more recognisable

As you know, currently only Yair, Martin and sometimes me use this project just to test control accessibilities.

Speaking what controls we are going to put, I expect we're going to add SidebarView, Toolbar, Omnibar and FolderView, all of which aren't standalone'd as of now.

Upgrade WinAppSdk to 1.6

We'd do this only when we have to use APIs or controls that are available only in 1.6

@0x5bfa
Copy link
Member

0x5bfa commented Nov 7, 2024

probably going a bit too much into a gallery app than a controls demo

Additionally, Should we decide to distribute these controls to public on NuGet.org (it'd be cool but it costs more our work), these changes would be good idea. But for now, we have never decided.

@Lamparter
Copy link
Contributor Author

probably going a bit too much into a gallery app than a controls demo

Additionally, Should we decide to distribute these controls to public on NuGet.org (it'd be cool but it costs more our work), these changes would be good idea. But for now, we have never decided.

This is exactly what I had in mind.

@0x5bfa
Copy link
Member

0x5bfa commented Nov 8, 2024

Ask @yaira2 if the logo should be added or not.
I think I can review other things.

Add a code section to each control to see how to implement it

We don't need it yet.

@yaira2 yaira2 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants