-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Improve UITests #16446
Comments
I was going to use ToggleSwitch on the right side of the caption buttons on the top of the window. But I didn't have much time to remake it and also this isn't user-facing, therefore I don't find it should be updated now.
I find it cool but maybe we'd like to keep the repo smaller and again it's not user-facing therefore I don't find it good idea. We should improve this project as we update controls.
I guess, we can move forward this.
I was going to add cards for the controls but we don't have as many controls as we can create them on the best layout.
As you know, currently only Yair, Martin and sometimes me use this project just to test control accessibilities. Speaking what controls we are going to put, I expect we're going to add SidebarView, Toolbar, Omnibar and FolderView, all of which aren't standalone'd as of now.
We'd do this only when we have to use APIs or controls that are available only in 1.6 |
Additionally, Should we decide to distribute these controls to public on NuGet.org (it'd be cool but it costs more our work), these changes would be good idea. But for now, we have never decided. |
This is exactly what I had in mind. |
Ask @yaira2 if the logo should be added or not.
We don't need it yet. |
Description
Right now, the UITests app is left in a rather sorry state:
So I'd like to take the effort to make it a little bit better.
Concerned code
tests/Files.App.UITests/
Gains
Requirements
Add a code section to each control to see how to implement it (probably going a bit too much into a gallery app than a controls demo)Comments
I have already made a start at
Lamparter:uitests
which I'll create a PR for once this I get the go-ahead on this.The text was updated successfully, but these errors were encountered: