-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded subtitle detected but not displayed #446
Comments
Interesting case. The subs are detected and codec open works, but we do not get any size info, which is why we do not render them. I created a PR #447 to optimistically assume subtitle size == video size. Then at least, the subs do appear. Not sure if it is such a good idea though. And looking at your screenshots, I just noticed that our colors are wrong as well, after applying the PR. They have black text and grey outline. That's the color info we get from ffmpeg, not much we can do about it. To me this looks like some pretty broken mux. I don't know much about PotPlayer internals, but many players use their own stream parsing and only do the decoding with ffmpeg. That could explain why PotPlayer displays the subtitles fine, maybe it's just more fault tolerant. |
The colors I think is something potplayer does, looks like some kind of accent color. |
Thanks, it worked perfectly. This how SubtitleEdit handles it as well: I've been using PotPlayer for over a decade, and for me, it's way better than KMPlayer or even VLC. |
Hi,
It seems that FFmpegInteropX can detect subtitles in this file, but selecting one does not display anything.
https://1drv.ms/u/c/4fffd835406c45f6/EZp0KGHrPb5PoW5hII3fbTYBNJLUjjjvF96DYssZ3E6V0Q?e=8VN9iQ
File info (truncated):
PotPlayer, however, shows the subtitles correctly:
Thanks in advance
The text was updated successfully, but these errors were encountered: