Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove Element on destroy() #26

Open
piranna opened this issue Mar 30, 2021 · 0 comments · May be fixed by #27
Open

Don't remove Element on destroy() #26

piranna opened this issue Mar 30, 2021 · 0 comments · May be fixed by #27

Comments

@piranna
Copy link

piranna commented Mar 30, 2021

p2p-graph/index.js

Line 261 in 3334451

self._root.remove()

When calling destroy(), the Element where the graph is being applied is removed from the DOM. Since this element is not created and managed by p2p-graph but instead provided by us, it should be left untouched, as it's done at https://github.com/Novage/p2p-media-loader/blob/85adce9b0edbc00dfa073321d93a61590af3afc8/p2p-media-loader-demo/index.html#L1234-L1240
piranna added a commit to piranna/p2p-graph that referenced this issue Mar 30, 2021
@piranna
Don't remove Element from DOM when calling destroy()
37dec3c 
Fix feross#26
@piranna piranna linked a pull request Mar 30, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't remove Element from DOM when calling destroy() piranna/p2p-graph
1 participant
@piranna