From 7bf9d8db23367ab632c97c17f6146efe8a651e21 Mon Sep 17 00:00:00 2001 From: Vijay A Date: Thu, 17 Oct 2024 08:46:51 +0530 Subject: [PATCH 1/4] Upgrade pnpm to 9.12.2 --- .github/workflows/builds.yml | 2 +- package.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index 9df457b25..aac6ba532 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -27,7 +27,7 @@ jobs: - name: Checkout code uses: actions/checkout@v4 - name: Install pnpm - uses: pnpm/action-setup@v3 + uses: pnpm/action-setup@v4 - name: Use Node.js specified in the '.nvmrc' file uses: actions/setup-node@v4 with: diff --git a/package.json b/package.json index 8225d5bfa..7644967ff 100644 --- a/package.json +++ b/package.json @@ -6,11 +6,11 @@ }, "engines": { "node": "20.18.0", - "pnpm": "9.12.0" + "pnpm": "9.12.2" }, "volta": { "node": "20.18.0", - "pnpm": "9.12.0" + "pnpm": "9.12.2" }, "engine-strict": true, "packageManager": "pnpm@9.12.0", From 4b169be62e8e22693f6f724bb9e6b877e6780628 Mon Sep 17 00:00:00 2001 From: Vijay A Date: Thu, 17 Oct 2024 12:23:37 +0530 Subject: [PATCH 2/4] Fix github workflow file pnpm command has to be run after node installation --- .github/workflows/builds.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index aac6ba532..adf40ffed 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -26,13 +26,13 @@ jobs: run: echo ${{ github.sha }} - name: Checkout code uses: actions/checkout@v4 - - name: Install pnpm - uses: pnpm/action-setup@v4 - name: Use Node.js specified in the '.nvmrc' file uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'pnpm' + - name: Install pnpm + uses: pnpm/action-setup@v4 - name: Install node dependencies recursively uses: nick-fields/retry@v3 with: @@ -42,6 +42,7 @@ jobs: retry_on: error - name: Check code style and formatting if: ${{ github.event_name == 'pull_request' }} - run: pnpm lint:fix && pnpm reformat-files - - name: Package recipes - run: pnpm package + run: | + pnpm lint:fix + pnpm reformat-files + pnpm package From a96248c2eddda55649221137467830976d799746 Mon Sep 17 00:00:00 2001 From: Vijay A Date: Thu, 17 Oct 2024 12:25:33 +0530 Subject: [PATCH 3/4] Remove cache setting while installing node --- .github/workflows/builds.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index adf40ffed..3a32dacf7 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -30,7 +30,6 @@ jobs: uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - cache: 'pnpm' - name: Install pnpm uses: pnpm/action-setup@v4 - name: Install node dependencies recursively From f651dc08fae3120727adbe0cb9414701498a5bac Mon Sep 17 00:00:00 2001 From: Vijay A Date: Thu, 17 Oct 2024 12:32:08 +0530 Subject: [PATCH 4/4] Revert pnpm upgrade --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 7644967ff..8225d5bfa 100644 --- a/package.json +++ b/package.json @@ -6,11 +6,11 @@ }, "engines": { "node": "20.18.0", - "pnpm": "9.12.2" + "pnpm": "9.12.0" }, "volta": { "node": "20.18.0", - "pnpm": "9.12.2" + "pnpm": "9.12.0" }, "engine-strict": true, "packageManager": "pnpm@9.12.0",