Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/alt-m handler fails "wysiwyg" #212

Open
WardCunningham opened this issue Dec 19, 2017 · 1 comment
Open

cmd/alt-m handler fails "wysiwyg" #212

WardCunningham opened this issue Dec 19, 2017 · 1 comment

Comments

@WardCunningham
Copy link
Member

We speculated, simple alt-m handler, might be best #206

We now think that this is not the case as explained in the following explanation quoted from chat.

I've had a few minutes this morning to look at Eric's make-a-new-plugin page and have found sure evidence of an "uncompleted cmd-m". This is an item from the page where a new type had been selected but no action sent that persists the selection.

    {
      "type": "factory",
      "id": "3888ea132a89c4f3",
      "text": "Tip: use conditions to export the right functions the right way at the right time:"
    },

We have no action that says "change type", only an action that says "replace whole item with edited version, including new type". The cmd-m sequence could have ended with this second action except that the text editor won't save a change that doesn't change the text.

This is not desirable behavior. This fails the "what you see is what you get" test. Eric sees the completed type conversion on his screen but has the conversion suspended at the factory menu state as persisted on his server.

@WardCunningham
Copy link
Member Author

I am now of the opinion that selecting a type from the factory menu should emit an edit action AND not return to the text editor as it now does. This will be NEW behavior for the factory menu which has been coded to always enter the editor after a type selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant