Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The vcs-diff tool needs correct dependency configuration #28

Open
jkonecny12 opened this issue May 17, 2024 · 3 comments
Open

The vcs-diff tool needs correct dependency configuration #28

jkonecny12 opened this issue May 17, 2024 · 3 comments
Assignees

Comments

@jkonecny12
Copy link
Collaborator

As it can be seen here #23 there is a lot of issues raise from missing packages in the pylint environment running the tests. We need to configure vcs-diff tool to install missing dependencies, ideally run poetry before the pylint execution.

@jkonecny12
Copy link
Collaborator Author

Hi @praiskup assigning you to this task as you have the best knowledge about vcs solution.

@praiskup
Copy link
Member

There's the install_rpm_packages option: https://github.com/fedora-copr/vcs-diff-lint-action/blob/861a4663fb6d6d02dd30c5586164098f20bc3d8a/README.md#install_rpm_packages

Anytime a new dependency is added, we can add a corresponding liter-time dependency. Or we can simply pylintrc ignore the import errors, up to you.

@jpodivin
Copy link
Collaborator

There's the install_rpm_packages option: https://github.com/fedora-copr/vcs-diff-lint-action/blob/861a4663fb6d6d02dd30c5586164098f20bc3d8a/README.md#install_rpm_packages

Anytime a new dependency is added, we can add a corresponding liter-time dependency. Or we can simply pylintrc ignore the import errors, up to you.

I don't believe all of our dependencies are in repositories, even if they were, this project is published on pipy, so rpms aren't really that relevant at this point. I'd rather have this disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants