frontend: always calculate the snippet indexes from the beginning #113
Conversation
|
looking good so far, I checked the indexes on chromium and firefox. Could you also please rebase to the current HEAD? since the backend part is not the latest so I want to test it against the latest BE just to be sure |
We have been collecting incorrect indexes. They aren't calculated from the end of the log but rather from the end of the previous node. I am currently working on fixing our collected data.
FrostyX
force-pushed
the
fix-snippet-indexes
branch
from
c12fc5c
to
f93049c
Compare
This will make our life much easier if we find out that snippet indexes are incorrect again
does this mean that some of our data may be wrong? |
There was a problem hiding this comment.
I can honestly say that I verified it now correctly works in Chrome. Because I accidentally checked out another PR where it was broken, then I correctly checked out this one and suddenly the indexes were right :)
$ podman exec a79b212b15f8 cat /persistent/results/2024-03-22/copr/7197868/1711110203.json > asdw.json
$ ipython3
Python 3.12.2 (main, Feb 7 2024, 00:00:00) [GCC 14.0.1 20240127 (Red Hat 14.0.1-0)]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.21.0 -- An enhanced Interactive Python. Type '?' for help.
In [1]: import pathlib
In [2]: import json
In [3]: p = pathlib.Path("./asdw.json")
In [4]: j = json.loads(p.read_text())
In [5]: c = j["logs"]["builder-live.log"]["content"]
In [6]: for s in j["logs"]["builder-live.log"]["snippets"]:\
...: print(f"'{c[s['start_index']:s['end_index']]}'\n'{s['user_comment']}'\n======")
'
Start: chroot in'
'start:'
======
'
E ModuleNotFoundError: No module named 'telnetli'
'E Module'
======
Those were the exact lines I selected.
@FrostyX++ for spotting it and resolving it so precisely
|
Thanks everybody for the reviews! It works for the most cases. However, there are 2 issues:
|
naive thinking: how about disabling removals? |
|
as per chat in slack - merging this to release this fix ASAP and deal with the edgecase later - #117 |
That would significantly lower the user experience, potentially lowering the feedbacks we get :/ I used this feature several times. In case I'll need to close it and fill it once again (as normal user) I'd probably left it without giving feedback |
We have been collecting incorrect indexes. They aren't calculated from the end of the log but rather from the end of the previous node.
I am currently working on fixing our collected data.