Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not have to specify BigQuery dataset in Source #4664

Open
danbaron63 opened this issue Oct 22, 2024 · 0 comments
Open

Not have to specify BigQuery dataset in Source #4664

danbaron63 opened this issue Oct 22, 2024 · 0 comments
Labels
kind/feature New feature or request

Comments

@danbaron63
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When declaring a BigQuerySource, for the table parameter you must at a minimum provide <dataset>.<table_name>. This is despite already providing the <dataset> and <gcp-project> in the feature_store.yaml. This means that the dataset must either be hardcoded into the source declaration or you must provide some custom logic to keep it consistent across your repo (can be difficult if you set up is complex and multi modular).

Describe the solution you'd like
When no dataset is provided in the table parameter, default to using the configured dataset in the feature_store.yaml. This would allow users to quickly switch between datasets on the fly (when working locally we load data into user datasets for example).

Describe alternatives you've considered
Implementing custom logic on top of feast to keep it consistent but this doesn't fit nicely into our current code setup, it would be nice if Feast just used this already configured variable by default.

Additional context
N/a

@danbaron63 danbaron63 added the kind/feature New feature or request label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant