Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite RemoteOnlineStore to use get_online_features #4343

Open
tokoko opened this issue Jul 11, 2024 · 2 comments
Open

Rewrite RemoteOnlineStore to use get_online_features #4343

tokoko opened this issue Jul 11, 2024 · 2 comments
Labels
kind/feature New feature or request

Comments

@tokoko
Copy link
Collaborator

tokoko commented Jul 11, 2024

Is your feature request related to a problem? Please describe.
Current implementation of RemoteOnlineStore makes several round trips to the feature server when multiple feature views are requested due to previous OnlineStore interface limitations.

Describe the solution you'd like
After #4319 it should be possible to implement RemoteOnlineStore by overriding the new get_online_features method instead of online_read which would enable it to work better with multiple feature views and feature services.
@tokoko tokoko added the kind/feature New feature or request label Jul 11, 2024
@tokoko
Copy link
Collaborator Author

tokoko commented Jul 11, 2024

FYI @lokeshrangineni

@dmartinol
Copy link
Contributor

@lokeshrangineni @redhatHameed we need to prioritize this task, once the RBAC PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tokoko @dmartinol