Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tests into own files #90

Open
patkan opened this issue Oct 23, 2015 · 5 comments
Open

move tests into own files #90

patkan opened this issue Oct 23, 2015 · 5 comments
Labels

Comments

@patkan
Copy link
Member

patkan commented Oct 23, 2015

Hi,
I would like to move all tests in separate files in their respective directories. The way we are doing it currently seems to be problematic since we try to execute all files but only some include tests.
Moreover this would be cleaner: we could separate the includes and code for tests and real logic.
If no one opposes until tonight, I will start separating the tests.

@patkan
Copy link
Member Author

patkan commented Oct 23, 2015

@fau-fablab/kasse please have a look at this issue.

@sedrubal
Copy link
Member

Even if my contribution to kasse was not that much, I think this would be a good idea...

@mgmax
Copy link
Member

mgmax commented Oct 23, 2015

no, we don't execute all files. all files must be importable, and all unittest.testcase subclasses are run.

@patkan
Copy link
Member Author

patkan commented Oct 23, 2015

Ok, you are right, my bad.
We search every source file, while typical test systems assume that tests reside in certain files (e.g. test_*.py)
The background for this that I try to get nearer to the de-facto-standards.
Currently, Travis is failing while building the unit test. I don't think this will fix the problem with Travis, but maybe it makes it easier to find errors.

@patkan patkan removed their assignment Nov 17, 2015
@patkan
Copy link
Member Author

patkan commented Nov 17, 2015

I drop this task for now because I do not have the time at the moment.

@mgmax mgmax removed the enhancement label Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants