Repository health increased by 0.06% when pulling fafec04 on improve-config-system into 4a4d884 on development.

• No new problems were introduced.
• 3 problems were fixed (including 0 errors and 0 code smells).

Renaming the config without changing the way the config system works is confusing, because the new name is just wrong. This should not be merged yet.

Repository health increased by 0.06% when pulling 8a5a637 on improve-config-system into ce0d8b3 on development.

• No new problems were introduced.
• 3 problems were fixed (including 0 errors and 0 code smells).

I changed the system by loading config.defaults.ini before loading config.ini, but I forgot to mention this in the commit message. See 8a5a637#diff-22cd404ff64283f596d2fe30d447f59dR96

(I just force pushed, because the PR was not clean. It contained changes of another PR)

This PR does not completely fix the broken config system, but it might be a step. The milestone ImproveConfig might help to keep in mind that further changes are required.

But doesn't this code simply load config.defaults.ini and then discard these settings and load config.ini if the latter file is present?
Or do these settings "overload" the old settings (thus adding only the changed parameters).

As far as I read and tested, the second reading overloads the settings of the first reading.

Example:

• config.defaults.ini contains support_mail but config.ini doesn't, the value set in defaults will be taken
• config.defaults.ini contains support_mail = change@me and config.ini contains support_mail = [email protected] the latter one will be accessible

Oh, I think we want to do it like this example: https://docs.python.org/2/library/configparser.html#ConfigParser.RawConfigParser.read (but maybe we want to check if config.ini exists)
#rtfm

From the source it looks quite good, but the documentation and handling of creating the first config needs to be changed. We don't really need a config anymore, maybe FabLabKasse should create some empty dummy config file with short instructions?

closing as WONTFIX