Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash on missing config option #63

Open
nightvisi0n opened this issue Sep 4, 2015 · 2 comments
Open

crash on missing config option #63

nightvisi0n opened this issue Sep 4, 2015 · 2 comments
Labels
bug
Milestone
ImproveConfig

Comments

@nightvisi0n
Copy link
Member

If a config option is missing (e.g. commented out) the terminal is crashing when it searches the config for it.
@patkan
Copy link
Member

patkan commented Sep 4, 2015

This should be solved while solving #43

@patkan patkan added the bug label Sep 4, 2015
patkan added a commit that referenced this issue Sep 5, 2015
@patkan
IMPROVE robustness of cart_from_app-code
acf5ef9 
 * raise Exception when no API-key is specified in config
   * relevant to #63
 * raise Exception when num_retries times the HTTP-requests fail
   * relevant to #17
 * catch the new Exceptions in GUI and inform the user (and abort cart import)
@patkan
Copy link
Member

patkan commented Sep 5, 2015

By the way: this happens only when the config is accessed without checking its existence.

@patkan patkan added this to the ImproveConfig milestone Sep 6, 2015
sedrubal pushed a commit that referenced this issue Nov 22, 2015
Made support-email configurable, fixes #100
7c528af 
 - needs testing,
 - is vulnerable to #63
@sedrubal sedrubal mentioned this issue Nov 22, 2015
Merged
sedrubal pushed a commit that referenced this issue Nov 22, 2015
Moved config.ini.example to config.defaults.ini
fafec04 
 - see #43
 - can fix #63
@sedrubal sedrubal mentioned this issue Nov 22, 2015
Closed
sedrubal pushed a commit that referenced this issue Nov 22, 2015
Moved config.ini.example to config.defaults.ini
8a5a637 
 - see #43
 - can fix #63
patkan pushed a commit that referenced this issue Jan 16, 2016
@patkan
Made support-email configurable, fixes #100
1f2531e 
 - needs testing,
 - is vulnerable to #63

This commit contains

9d1b4de
Fixed syntax, TODO: cfg

and

0ffd19a
FIX pass cfg object into payment_methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
ImproveConfig
Development

Successfully merging a pull request may close this issue.

Moved config.ini.example to config.defaults.ini fau-fablab/FabLabKasse
2 participants
@patkan @nightvisi0n