Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference ellipsoids for the Moon, Venus and Mercury #53

Closed
santisoler opened this issue Oct 7, 2020 · 3 comments
Closed

Add reference ellipsoids for the Moon, Venus and Mercury #53

santisoler opened this issue Oct 7, 2020 · 3 comments
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)

Comments

@santisoler
Copy link
Member

santisoler commented Oct 7, 2020

Description of the desired feature

With the new Sphere class introduced in #42 for representing reference ellipsoids with zero flattening, now we are in position to add ellipsoids for planetary bodies that are usually treated as spheres, such as the Moon, Venus and Mercury.

@leouieda started adding the reference ellipsoid for the Moon on #13 before we had the Sphere class for that purpose, encountering the known problems of singularities due to division by zero (see #18).

The idea is to add new MOON, VENUS and MERCURY instances of the Sphere class with the correct parameters for the each body (they can be taken from Wieczorek (2015)). These three variables should be defined in the boule/realizations.py file.

Are you willing to help implement and maintain this feature?
Yes, I'm willing to help anyone that wants to implement it (yes, I'm talking to you)! 🚀

If you want to add just one of these bodies, it's ok: we can add each one of them on separated PRs.

@santisoler santisoler added enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project) help wanted labels Oct 7, 2020
@santisoler santisoler changed the title Add reference ellipsoid for the Moon Add reference ellipsoids for the Moon, Venus and Mercury Oct 7, 2020
@dabiged dabiged mentioned this issue Nov 9, 2020
6 tasks
@dabiged
Copy link
Contributor

dabiged commented Nov 9, 2020

Hi All, first time contributor to boule.
I have had a go at adding VENUS. I am not sure about the syntax exactly in the declaration (sphere vs spheroid) or the doctest (should I test for semi-major axis and/or radius).

I am happy to take directions from more senior maintainers.

leouieda pushed a commit that referenced this issue Nov 9, 2020
Add the Venus spheroid from Weiczorek (2015) as an instance 
of `Sphere`. See #53
@leouieda
Copy link
Member

leouieda commented Nov 9, 2020

@dabiged thanks for the PR 🙂 For Sphere, you could use either radius or semimajor_axis since it sets them both to the same value. Otherwise, all looks on and PR is merged (there was a slight mistake in the radius with a trailing 0 that shouldn't be there).

@leouieda
Copy link
Member

leouieda commented Nov 9, 2020

That's what happens when I have 30 minutes to spare and don't want to open my emails 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)
Projects
None yet
Development

No branches or pull requests

3 participants