Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested objects data not accessible #12

Open
gap777 opened this issue Oct 22, 2018 · 4 comments
Open

Nested objects data not accessible #12

gap777 opened this issue Oct 22, 2018 · 4 comments

Comments

@gap777
Copy link
Contributor

gap777 commented Oct 22, 2018

The Harvest v2 API returns nested objects, e.g. project.client, user_assignment.project, user_assignment.user, time_entry.user, etc. Harvesting's dynamic accessor generation scheme only supports accessing a flat data structure. In order to access all the data returned via the Harvest v2 API, the Harvesting Models need methods that access nested data.

@etagwerker
Copy link
Member

@gap777 Thanks for submitting this issue and this PR: #15

I believe we are on the right track to add all nested objects. I think your PR adds support for some of them and should be used as a guide for more nested objects.

Once we make sure all nested objects are accessible we can close this issue.

@etagwerker
Copy link
Member

@gap777 Is this solved now? I am not sure we have covered all nested objects yet.

@gap777
Copy link
Contributor Author

gap777 commented Jan 17, 2019

I agree with you - there's a lot that could be included (eg Estimates API, Roles, Company). Maybe wait until someone asks for more pieces and add them then?

@chimedpalden
Copy link

chimedpalden commented Jan 31, 2019

@etagwerker i can give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants