Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvstore, InsertKVStoreKey() does not support if-generation-match #573

Open
t-geindre opened this issue Dec 19, 2024 · 3 comments
Open

kvstore, InsertKVStoreKey() does not support if-generation-match #573

t-geindre opened this issue Dec 19, 2024 · 3 comments
Labels

Comments

@t-geindre
Copy link

As stated here, a if-generation-match parameter allows to make sure the insert is replacing the right version.

This parameter is missing from the client function args.

And I'm not sure if there is a way to get the generation ID while reading a key value either.

@kpfleming kpfleming added the bug label Dec 19, 2024
@kpfleming
Copy link
Contributor

Thanks for the report! Generally speaking go-fastly is primarily used by the Fastly CLI and the Fastly Terraform provider, so we're most likely to see gaps like this when working on those tools... which also means that if those tools don't try to use every API feature available, some of those features won't be added to go-fastly.

Normally I'd consider this a feature request but since it interferes with safely using the API endpoints, I've marked it as a bug.

@kpfleming
Copy link
Contributor

We'll also be working on improving the API docs for the KV Store, since as you pointed out they are lacking in some areas.

@t-geindre
Copy link
Author

Thank for your answer.
I understand the purpose of this package but we are using it to populate our kv-stores using Go et it would be very appreciated if it could implement all the available API features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants