-
Notifications
You must be signed in to change notification settings - Fork 356
libedit/readline compatibility #22
Comments
This is my patch to build it:
|
@denji could you try the new build instructions published by @jwatzman? Specifically,
The settings above fixed the build for me. https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-OSX-10.10 |
@wjywbs your changes do not affect the build, homebrew priority uses the path
The problem in cmake/readline.cmake, it does not support tests for latest readline. |
Something about that superenv stuff either isn't working as expected, or isn't making it thru HHVM into the webscalesql subproject that HHVM builds. Those two lines definitely fixed this issue for me as well, that's why I added them :)
I thought this was due to BSD's readline being weird, but I'm not totally sure on this one. |
Trying to figure out how to build on 10.11.4 with hints from above and I get the errors below. Any ideas? cd webscalesql/build ... |
When try to pass tests readline, webscalesql-5.6 falls
readline version
build log
edit_USE_NEW_READLINE_INTERFACE
The text was updated successfully, but these errors were encountered: