weird Enum pattern causes problems for clients

[andersonbd1]

Wouldn't it make more sense for your Enum constants to look like this:

  public static enum EnumCustomerFileSource {
      BOTH_USER_AND_PARTNER_PROVIDED,
      PARTNER_PROVIDED_ONLY,
      ...
      // NULL isn't necessary
  }

as opposed to this:

  public static enum EnumCustomerFileSource {
      @SerializedName("BOTH_USER_AND_PARTNER_PROVIDED")
      VALUE_BOTH_USER_AND_PARTNER_PROVIDED("BOTH_USER_AND_PARTNER_PROVIDED"),
      @SerializedName("PARTNER_PROVIDED_ONLY")
      ...
      NULL(null);

      private String value;

      private EnumCustomerFileSource(String value) {
        this.value = value;
      }

      @Override
      public String toString() {
        return value;
      }
  }

it's less code, simpler, and avoids problems like this for clients:
FasterXML/jackson-databind#2309

[andersonbd1]

@jingping2015 - any thoughts on this?

[jingping2015]

Hi ,
Thanks for reporting this issue. Actually @SerializedName annotation is used for serializing and deserializing by GSON. So we are not be able to just have enum constants like you proposed.

[andersonbd1]

Thanks @jingping2015 . What about the NULL(null);. Is that really necessary? It doesn't work with Jackson (see link above).