Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add support for M1 chips #2684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for M1 chips #2684

wants to merge 1 commit into from

Conversation

marcesengel
Copy link
Contributor

@marcesengel marcesengel commented Mar 3, 2022 •
edited
Loading

Fixes #2666. Updated jna, java-objc-bridge, sqlite-jdbc and zstd-jni to supported versions.

Breaks java 8 support due to bumping java-objc-bridge, see shannah/Java-Objective-C-Bridge#41 (comment).

  • Note dropped Java 8 support in README
  • Remove CircleCI tests for Java 8

@marcesengel marcesengel mentioned this pull request Mar 3, 2022
Open
@Solace-Studios
Copy link

@marcesengel Hey Marc, what java version should I use with this while Facebook works on merging this?

@marcesengel @cortinico
feat: support M1 chips
8c2ebf0 
Updated jna, java-objc-bridge, sqlite-jdbc and zstd-jni to supported version

Breaks java 8 support due to java-objc-bridge bump
shannah/Java-Objective-C-Bridge#41 (comment)
@cortinico
Copy link
Contributor

Hey @marcesengel I would love to see this moving forward.

Could you update the CircleCI config to install JDK 11:

buck/.circleci/config.yml

Lines 47 to 57 in 16dc486

install_openjdk8: &install_openjdk8
name: Install OpenJDK8
command: |
if [ "${PLATFORM}" == "linux" ]; then
sudo apt-get update && sudo apt-get install openjdk-8-jdk
sudo update-java-alternatives -s java-1.8.0-openjdk-amd64
elif [ "${PLATFORM}" == "macos" ]; then
brew install openjdk@8
export PATH="/usr/local/opt/openjdk@8/bin:$PATH"
fi
java -version

and update the JAVA_HOME version in the CircleCI config, like here:

https://github.com/facebook/buck/blob/main/.circleci/config.yml#L200

To point to JDK 11?

@bigfootjon
Copy link
Member

@marcesengel are you still working on this? Or would you mind if someone else took this over?

@marcesengel
Copy link
Contributor Author

marcesengel commented Oct 28, 2022 •
edited
Loading

This PR only allows us to build on M1 IIRC, not sure if everything works with that build though - I still had some issues building react-native with the resulting build of buck.

I'd be open to pass this on, as it sadly wasn't getting any contributor traction when I had the time and need to add support (which I can understand, people have a life outside open source).

@cortinico
Copy link
Contributor

I'd be open to pass this on, as it sadly wasn't getting any contributor traction when I had the time and need to add support (which I can understand, people have a life outside open source).

Totally understand :) I'll take this over then 🙏

@nicoburns nicoburns mentioned this pull request Dec 29, 2022
Closed
1 task
@cortinico
Copy link
Contributor

Totally understand :) I'll take this over then 🙏

Just a heads up that I won't have capacity to do this one. I looked into it but it's harder than expected + we dropped support for Buck 1 OSS on React Native as we're looking into potentially adopting Buck 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M1 Support
5 participants
@marcesengel @Solace-Studios @cortinico @bigfootjon @facebook-github-bot