Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Amulet which removes/reduces dimension fog #112

Open
valoeghese opened this issue Oct 6, 2019 · 3 comments
Open

Idea: Amulet which removes/reduces dimension fog #112

valoeghese opened this issue Oct 6, 2019 · 3 comments
Labels
idea discussion General idea discussion

Comments

@valoeghese
Copy link
Member

The amulet should be found in one of the major planned dungeons. Wearing the said amulet removes or reduces the fog in the dimension for the wearer, likely through a mixin to the fog rendering code.

@Draylar
Copy link
Contributor

Draylar commented Oct 7, 2019

Expanding on this (and repeating a discussion in discord), it may be best to write our own fog renderer. The vanilla one (which is just a call to the GL fog renderer) doesn't look good. If we did this, we could allow each biome to define fog color & intensity, which would make it easier to implement "if the player is wearing this ring, don't render the fog" kind of logic.

@vini2003 vini2003 added the idea discussion General idea discussion label Oct 9, 2019
@valoeghese
Copy link
Member Author

Now that we have more control over fog rendering, maybe this idea could be implemented?

@MariaTheDinkus
Copy link
Member

It could, although Pyrofab is working on our own custom fog it seems, which is why I haven't bothered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea discussion General idea discussion
Projects
None yet
Development

No branches or pull requests

4 participants