-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Email Sign-Up Due to "+" Character #333
Comments
@ollebergkvist could you provide more context, because valibot supports email in format like [email protected] ? |
Thank you for creating this issue. I will take a look at it once we have more details. As a workaround, you can use one of these regex along with our W3C Working Draft Regex from w3.org:
HTML Standard Regex from whatwg.org:
|
It seems that it doesn't work when a |
Thanks for the info. That could be the problem. Let's wait for @ollebergkvist's reply. |
And maybe take a look at issue #204 to understand why |
@sqmasep @fabian-hiller i added a test here #276 and, it is working for + in the begining and ending of local part. Maybe it is no the issue in '+'character @ollebergkvist? So we would need more context on it. |
Sorry, I've been away for a couple of days. The email that triggers the error is: Running: |
I invested additional time in debugging the problem. The validation error triggered by valibot for emails with a '+' symbol didn't occur due to the validation process rejecting emails containing '+'. Instead, the issue stemmed from our oversight in encoding/decoding the query parameter passed to valibot. Consequently, valibot misinterpreted the '+' symbol as a space. Thanks and sorry for the false alarm here! |
We recently received a support ticket from a client who faced difficulties signing up for our app because their email contained a "+". The valibot validation for the email() method prevented the sign-up process.
I'm aware that many email providers do not permit the use of the "+" character. However, I'd like to highlight that reputable providers, such as ProtonMail, now allow its usage in email addresses (https://proton.me/mail).
The text was updated successfully, but these errors were encountered: