-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent Color Mapping and Proposal for Custom Color Replacement #108
Comments
Now that I think about it, you could just create themes, tweak them, and use those instead of making a function to replace colors. This project is really well thought out lol. I guess I'll wait for some feedback before closing the issue, but I think that could be a really good alternative. |
ah the color mapping, really pywal colorschemes are more geared to have a pseudo grayscale contrast, the colors that tend to contrast and be accent and secondary accent are background, foreground, 0, 15 (color 0 and background aren't always the same tho) color 4 (and 12) (accent) color 2 (and 10) secondary accent. those are the more or less guaranteed-ish color combinations that will be different enough, that is how dylan built pywal and in pywal16 that doesn't change only that we can get the additional color shades.
yeh that can be done if you want
i'll be honest not very often i read, hear or even think that about pywal. |
yeh pywal wasn't really designed for keeping the semantic meaning of colors, is more of a looking pretty than being functional in that regard (tho that is a core fundament of ricing that some functionality may be hampered in favour of aesthetics) i personally have forgotten what the semantic meanings of colors were even supposed to mean... i'm just used to seeing things as colorful greyscale and relying on the actual error messages and warning symbols instead of on specific colors, tho i know there are some efforts to try and add color semantization to pywal and i would not be opposed to eventually merging that to pywal16 but not as the default behaviour but rather an option as not even the generation of 16 shades of colors is the default on pywal16 even now that the current master can generate the 16 shades for the old built in themes that were just 9 colors (colors 1 to 7 were the same as colors 9 to 15) |
Description
I have this problem/nitpick/thingy with the color generation, the "inconsistency" of colors when processing images. For instance:
1
,3
, and5
might form a gradient based on the primary color.I get that this is just how pywal works, but I’ve been thinking about a way to handle this with custom color replacements for specific images.
Possible solutions
Example of the JSON:
Questions
Let me know what you think about this idea.
The text was updated successfully, but these errors were encountered: